refactor: custom store implementation #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report between this PR and the main branch |
Shahroz16
reviewed
Sep 12, 2024
| func _newState(state: Any) | ||
| } | ||
|
|
||
| public protocol StoreSubscriber: AnyStoreSubscriber { |
There was a problem hiding this comment.
this might not be needed as we creating the same thing in alias.
There was a problem hiding this comment.
To keep store generic and copy tests, it will be needed
|
@Shahroz16 Yes, tests will be added later in future PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of MBL-480
Changes
ReSwiftdependency so that pods can work without any workaroundsInAppMessageMiddlewarefile as private implementation to avoid naming conflicts in other filesInAppMessageActioneverywhereReSwiftand modified them as needed to maintain the custom store functionality:AssertionsMiddlewareReducerStoreStoreSubscriberSubscriptionSynchronized